Support composite arg type parsing in dspy.Tool
#8095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomeHirata
reviewed
Apr 23, 2025
| @@ -159,3 +159,17 @@ def foo(x=100): | |||
| tool = Tool(foo) | |||
| assert tool.args["x"]["default"] == 100 | |||
| assert not hasattr(tool.args["x"], "type") | |||
|
|
|||
|
|
|||
| def test_tool_call_parses_args(): | |||
There was a problem hiding this comment.
nit: Can we also add a unit test for the nested type like list[DummyModel]?
There was a problem hiding this comment.
good call!
TomeHirata
reviewed
Apr 23, 2025
| } | ||
| } | ||
|
|
||
| result = tool(**args) |
There was a problem hiding this comment.
Q: What are the types we officially support as tool-callable for ReAct? Python primitives + Pydantic?
There was a problem hiding this comment.
yes, everything supported by typing + pydantic
|
LGTM, thank you @chenmoneygithub !! Thanks for the review @TomeHirata ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our arg parsing cannot handle composite type like
list[MyPydanticModel], so we make this PR to resolve the issue.The solution is creating a pydantic wrapper with one single dummy field
valueof the arg type, and utilize pydanticmodel_validate()to convert the LLM-generated args (json format) into the right type.