Add tests for Unbatchify util #8076
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assadyousuf
commented
Apr 17, 2025
|
|
||
|
|
||
| def submit(self, input_item: any) -> Future: | ||
| """Submits an item for processing and returns a Future.""" |
There was a problem hiding this comment.
Needed to monkey patch Unbatchify.__ call __ because its a blocking call. Needed a workaround that provides a non blocking way to add items to the queue
|
@okhat Would love to get some eyes on this when you get a chance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tests for Unbatchify util. Seemed to be the only Util missing a test