Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CohereLocalTokenizer #2623

Merged
merged 4 commits into from
May 21, 2024
Merged

Add CohereLocalTokenizer #2623

merged 4 commits into from
May 21, 2024

Conversation

yifanmai
Copy link
Collaborator

@yifanmai yifanmai commented May 7, 2024

Add CohereLocalTokenizer, which uses the Cohere Python library to perform tokenization locally.

This will eventually allow us to delete CohereWindowService, which was intended to work around token limits on the Cohere remote tokenization API.

@yifanmai yifanmai marked this pull request as ready for review May 8, 2024 21:36
@yifanmai yifanmai requested a review from farzaank May 18, 2024 00:09
@yifanmai yifanmai force-pushed the yifanmai/fix-cohere-tokenizer branch from f137853 to fd39697 Compare May 20, 2024 20:55
@yifanmai
Copy link
Collaborator Author

@farzaank PTAL

@farzaank
Copy link
Contributor

taking a look now

Copy link
Contributor

@farzaank farzaank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yifanmai yifanmai merged commit 8f29d35 into main May 21, 2024
6 checks passed
@yifanmai yifanmai deleted the yifanmai/fix-cohere-tokenizer branch May 21, 2024 20:22
xuwangyin pushed a commit to xuwangyinx/helm that referenced this pull request Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants