Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename some model names for consistency #2596

Merged
merged 1 commit into from
May 3, 2024
Merged

Rename some model names for consistency #2596

merged 1 commit into from
May 3, 2024

Conversation

yifanmai
Copy link
Collaborator

@yifanmai yifanmai commented May 1, 2024

  • Rename Claude because our convention excludes model creator organization names from the model name
  • Rename DeepSeek to DeepSeek LLM becauase that is the official name

@yifanmai yifanmai requested review from percyliang and farzaank May 1, 2024 21:08
@yifanmai yifanmai marked this pull request as ready for review May 1, 2024 21:08
farzaank
farzaank approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@farzaank farzaank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense for Claude- Deepseek LLM has a weird enough name that I feel the previous name was sensible, but for consistency this makes sense too.

@yifanmai yifanmai merged commit 20148be into main May 3, 2024
6 checks passed
@yifanmai yifanmai deleted the yifanmai/fix-model-names branch May 3, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farzaank farzaank farzaank approved these changes

@percyliang percyliang Awaiting requested review from percyliang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yifanmai @farzaank