Update laplace signatures to have hessian_block_size before covariance function#1599
Open
Update laplace signatures to have hessian_block_size before covariance function#1599
Conversation
4 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1599 +/- ##
==========================================
- Coverage 90.33% 90.31% -0.02%
==========================================
Files 65 65
Lines 10028 10051 +23
==========================================
+ Hits 9059 9078 +19
- Misses 969 973 +4
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See stan-dev/math#3286 (comment)
As per usual with these laplace functions, most of the diff is in the error messages and tests.
Also adds the
generate_laplace_optionshelpers and restrictsintegrate_1dinside laplace (stan-dev/math#3280)Submission Checklist
Release notes
Updated signatures of the embedded laplace approximation functions.
Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)