Mark binomial logit and glm as opencl-supported#1368
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1368 +/- ##
=======================================
Coverage 89.49% 89.49%
=======================================
Files 63 63
Lines 10618 10618
=======================================
Hits 9503 9503
Misses 1115 1115
|
Member
|
With #1353 this may be obsolete by the next release but I don't see any harm in marking it supported if it is |
Contributor
Author
Oh neat, that will be really nice to have |
Contributor
Author
|
@WardBrian would it be alright for this to go in? |
WardBrian
approved these changes
Oct 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist
This PR marks the
binomial_logitandbinomial_logit_glmdistributions as OpenCL-supported. Thebinomial_logit_glmsupport was only recently added, but thebinomial_logitdistributions appears to have already had support but just hadn't been enabled.Let me know if I've missed any tests/checks that also need to be made!
Release notes
Enabled OpenCL support for the
binomial_logitandbinomial_logit_glmdistributionsCopyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)