Skip to content

Added STAN_NO_RANGE_CHECKS helper #2437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Conversation

bbbales2
Copy link
Member

Summary

Added a makefile helper so:

STAN_NO_RANGE_CHECKS=true

is shorthand for

CXXFLAGS += -DSTAN_NO_RANGE_CHECKS

Tests

None

Release notes

  • Allow STAN_NO_RANGE_CHECKS=true in make/local to turn off range/size checks

Checklist

  • Math issue [FR] No bounds checks when NDEBUG flag is set #2420

  • Copyright holder: Columbia University

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

@bbbales2 bbbales2 requested a review from rok-cesnovar March 22, 2021 12:54
@bbbales2
Copy link
Member Author

A very complex pull for you to review @rok-cesnovar

Copy link
Member

@rok-cesnovar rok-cesnovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Free Github pointz! Collect them all.

@rok-cesnovar
Copy link
Member

Thanks!

@bbbales2
Copy link
Member Author

bbbales2 commented Mar 22, 2021

@rok-cesnovar mystery error here: https://jenkins.mc-stan.org/blue/organizations/jenkins/Math%20Pipeline/detail/PR-2437/1/pipeline . Just need to restart tests or seems like something legit?

Edit: Uh oh looks like it's happening over here too: https://jenkins.mc-stan.org/blue/organizations/jenkins/Math%20Pipeline/detail/PR-2434/5/pipeline

@rok-cesnovar
Copy link
Member

This is a configuration issue (although I dont understand why it find the platform in one occasion but not in others).

@stan-buildbot
Copy link
Contributor


Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan 3.32 3.41 0.97 -2.72% slower
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.02 0.02 0.98 -2.19% slower
eight_schools/eight_schools.stan 0.11 0.12 0.96 -3.71% slower
gp_regr/gp_regr.stan 0.16 0.16 1.0 0.35% faster
irt_2pl/irt_2pl.stan 5.38 5.34 1.01 0.76% faster
performance.compilation 90.95 89.0 1.02 2.14% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 8.61 8.64 1.0 -0.38% slower
pkpd/one_comp_mm_elim_abs.stan 30.14 30.49 0.99 -1.16% slower
sir/sir.stan 127.71 122.24 1.04 4.28% faster
gp_regr/gen_gp_data.stan 0.03 0.03 1.01 0.53% faster
low_dim_gauss_mix/low_dim_gauss_mix.stan 3.22 3.24 0.99 -0.65% slower
pkpd/sim_one_comp_mm_elim_abs.stan 0.38 0.38 1.0 -0.3% slower
arK/arK.stan 2.0 1.99 1.01 0.68% faster
arma/arma.stan 0.95 0.95 1.01 0.57% faster
garch/garch.stan 0.51 0.52 0.98 -1.99% slower
Mean result: 0.997841922696

Jenkins Console Log
Blue Ocean
Commit hash: 7ebacab


Machine information ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

@rok-cesnovar rok-cesnovar merged commit 9fca1b4 into develop Mar 24, 2021
@rok-cesnovar rok-cesnovar deleted the feature/issue-2420-2 branch March 24, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants