Revert "Feature/elementwise checks revert revert" #2147
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #2007 (which was originally #1798)
We've gotta revert the elementwise checks again. They are not quite fast enough. We were seeing across the board 10% hits to performance on non-vectorized unmodified lpdfs between develop yesterday (#50d56cc7) and a commit from August 12th (#3492945).
Code for benchmarking is here
The results were August 12th:
And then develop (October 9th):
You can bisect this down and find that #a406e8a7 (August 20th) is slow but #8a67bc7b (August 19th) is fast.
Next time we put this in (we still want these), we'll just need to add overloads so that the basic stuff is fast.