Skip to content

fix develop #1712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2020
Merged

fix develop #1712

merged 1 commit into from
Feb 15, 2020

Conversation

rok-cesnovar
Copy link
Member

@rok-cesnovar rok-cesnovar commented Feb 14, 2020

Summary

Fix for develop. PR #1628 that was merged last has removed fwd/fun/dot_product.hpp. However PR #1698 added an include to that file. PR #1698 was merged after the tests in #1628 passed and there was no conflict that would require an additional merge and tests. Hence this PR.

Tests

/

Side Effects

/

Checklist

  • Copyright holder: Rok Češnovar

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

@stan-buildbot
Copy link
Contributor


Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan 4.98 4.97 1.0 0.25% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.02 0.02 0.98 -2.26% slower
eight_schools/eight_schools.stan 0.09 0.09 1.01 0.95% faster
gp_regr/gp_regr.stan 0.22 0.22 0.99 -1.44% slower
irt_2pl/irt_2pl.stan 6.06 6.08 1.0 -0.4% slower
performance.compilation 88.01 86.95 1.01 1.21% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 7.49 7.46 1.0 0.31% faster
pkpd/one_comp_mm_elim_abs.stan 21.1 21.28 0.99 -0.85% slower
sir/sir.stan 97.82 89.78 1.09 8.22% faster
gp_regr/gen_gp_data.stan 0.04 0.05 0.99 -0.8% slower
low_dim_gauss_mix/low_dim_gauss_mix.stan 3.01 2.99 1.01 0.61% faster
pkpd/sim_one_comp_mm_elim_abs.stan 0.31 0.34 0.94 -6.61% slower
arK/arK.stan 1.75 1.74 1.01 0.66% faster
arma/arma.stan 0.77 0.8 0.97 -3.32% slower
garch/garch.stan 0.58 0.59 0.99 -0.79% slower
Mean result: 0.998068898787

Jenkins Console Log
Blue Ocean
Commit hash: 0034f24


Machine information ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

@mcol mcol merged commit ae0fad9 into develop Feb 15, 2020
@mcol mcol deleted the bugfix/failing_develop branch February 15, 2020 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants