-
-
Notifications
You must be signed in to change notification settings - Fork 193
Bugfix/include what you use in /prim/fun #1711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…cluded by other files
…stable/2017-11-14)
# Conflicts: # stan/math/prim/fun/matrix_exp.hpp
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for the little cleanups on locals and header ordering too!
Summary
This fixes a bunch of include-what-you-use issues in /prim. There are a lot of functions and files like the ones mentioned in #1704 with missing includes of stan/math/prim/fun/exp.hpp and the rest.
These functions dont have much issues in practice, because we usually include master header files that include all files. But that doesnt mean that this should be cleaned up.
I made a simple Python script that flagged these files which I then fixed.
Example on prim/fun/beta.hpp (comments stripped):
There is a missing
#include <stan/math/prim/fun/exp.hpp>
here which this PR adds. And that is it.It also does some smaller changes:
Tests
/
Side Effects
/
Copyright holder: Rok Češnovar