Skip to content

Move vectorize files to meta folder #1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2020

Conversation

mcol
Copy link
Contributor

@mcol mcol commented Jan 30, 2020

Summary

This removes the vectorize directory and vectorize.hpp, by moving headers to the meta folder and meta.hpp. Fixes #1595.

Tests

No new tests.

Side Effects

None.

Checklist

  • Math issue Move /vectorize files to /meta #1595

  • Copyright holder: Marco Colombo

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

@mcol mcol requested a review from rok-cesnovar January 30, 2020 20:41
Copy link
Member

@rok-cesnovar rok-cesnovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Marco. Looks great.

@rok-cesnovar rok-cesnovar merged commit fb31760 into develop Jan 31, 2020
@mcol mcol deleted the cleanup/1595-vectorize-to-meta branch January 31, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move /vectorize files to /meta
2 participants