Replace META_VAULT_ID with META_VAULT_IDS list#185
Merged
evgeny-stakewise merged 2 commits intomasterfrom Mar 9, 2026
Merged
Conversation
Remove per-network META_VAULT_ID from BaseNetworkConfig and add a module-level META_VAULT_IDS list derived from all MetaVault impl names via keccak. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR removes the per-network META_VAULT_ID from BaseNetworkConfig and replaces it with a single module-level META_VAULT_IDS list derived from keccak(text=impl_name) for the supported MetaVault implementations, along with a package version bump.
Changes:
- Removed
META_VAULT_IDfromBaseNetworkConfigand from allNETWORKSentries. - Added module-level
META_VAULT_IDScomputed from the 5 MetaVault implementation names. - Bumped package version to
v0.12.11.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
sw_utils/networks.py |
Removes per-network META_VAULT_ID and introduces a shared META_VAULT_IDS list for MetaVault ID matching. |
pyproject.toml |
Bumps the library version to v0.12.11. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cyc60
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.