fix(map-layers): stop layers shown even if disabled #884
+65
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreashelms
commented
Jan 13, 2025
app/util/mapLayerUtils.js
Outdated
| } | ||
| }); | ||
| } else if (layerOptions.stop[key] && allModes.includes(key)) { | ||
| if (layerOptions.stop[key] && allModes.includes(key)) { |
There was a problem hiding this comment.
I am not sure whether the lockedMapLayers are needed for StadtNavi at all or if the could removed from code completely.
There was a problem hiding this comment.
We should not remove upstream functionality. Could you introduce a config variable like "enableLockedMapLayers" (with default = true if unset)
hbruch
requested changes
Jan 27, 2025
app/util/mapLayerUtils.js
Outdated
| } | ||
| }); | ||
| } else if (layerOptions.stop[key] && allModes.includes(key)) { | ||
| if (layerOptions.stop[key] && allModes.includes(key)) { |
There was a problem hiding this comment.
We should not remove upstream functionality. Could you introduce a config variable like "enableLockedMapLayers" (with default = true if unset)
andreashelms
force-pushed
the
fix/map-layer-stops-locked
branch
from
e8de1e1 to
5f56cfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #883
closes #790