refactor(itinerary): adapt itinerary-page component to upstream #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbruch
requested changes
Dec 1, 2024
Comment on lines
257
to
259
| parkAndRide, | ||
| car, | ||
| onDemandTaxi, |
There was a problem hiding this comment.
I dont't think we should remove these stadtnavi additions.
There was a problem hiding this comment.
These props were not used in that component at all.
Comment on lines
311
to
314
| scooter={scooter} | ||
| parkAndRide={parkAndRide} | ||
| car={car} | ||
| onDemandTaxi={onDemandTaxi} |
There was a problem hiding this comment.
We should not remove stadtnavi additions
andreashelms
force-pushed
the
refactor/itinerary-page-cleanup
branch
2 times, most recently
from
5834d83 to
0710ff8
Compare
andreashelms
force-pushed
the
refactor/itinerary-page-cleanup
branch
3 times, most recently
from
f8a6472 to
2c073e2
Compare
andreashelms
force-pushed
the
refactor/itinerary-page-cleanup
branch
from
2c073e2 to
ec31263
Compare
hbruch
approved these changes
Dec 5, 2024
andreashelms
force-pushed
the
refactor/itinerary-page-cleanup
branch
from
fdf8904 to
61079cc
Compare
andreashelms
force-pushed
the
refactor/itinerary-page-cleanup
branch
from
61079cc to
fe61323
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply upstream refactorings to itinerary-page component and sub components