Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set car / park+ride limits #729

Open
wants to merge 3 commits into
base: next
Choose a base branch
from
Open

Conversation

Beck-berry
Copy link

@Beck-berry Beck-berry commented Jun 29, 2021

Proposed Changes

#673

  • set minimum car limit to 1000 meters - excepts when "avoid walking" or "wheelchair" option is set
  • remove park+ride options if even the fastest would be slower than any public transport suggestion

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors
  • Changes are documented or they are self explanatory
  • This pull request does not have any merge conflicts
  • All existing tests pass in CI build
  • Code coverage does not decrease (unless measured incorrectly)

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in a Jira issue
  • Merge the pull request

@Beck-berry Beck-berry self-assigned this Jun 29, 2021
@Beck-berry Beck-berry changed the title Feature/#673 car limits Set car / park+ride limits Jun 29, 2021
Copy link
Collaborator

@leonardehrenfried leonardehrenfried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leonardehrenfried
Copy link
Collaborator

@Beck-berry Can you please take a look at my comment and rebase the branch onto the latest changes?

@Beck-berry
Copy link
Author

Beck-berry commented Aug 8, 2021

Please check again, I rebased and then saw the park+ride offers on both localhost and production.

If it's still not good, suggestCarMinDistance config variable could be lowered 🤔

@Beck-berry Beck-berry force-pushed the feature/#673-car_limits branch from f4b2536 to f6628ed Compare August 8, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants