Merge pull request #874 from stadtnavi/fix/itinerary-list-wrong-entries

fix(itinerary-list): contains non transit entries
stadtnavi · Jan 13, 2025 · d6e08db · d6e08db
2 parents d0bbff3 + 30abb95
commit d6e08db
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/app/component/ItineraryPage.js b/app/component/ItineraryPage.js
@@ -313,6 +313,11 @@ class ItineraryPage extends React.Component {
           ]),
         };
 
+        const parkRidePlan = {
+          ...result.parkRidePlan,
+          itineraries: transitItineraries(result.parkRidePlan.itineraries),
+        };
+
         this.setState(
           {
             loadingAlt: false,
@@ -324,7 +329,7 @@ class ItineraryPage extends React.Component {
             scooterRentAndPublicPlan: result.scooterRentAndPublicPlan,
             carPlan: result.carPlan,
             carRentalPlan: result.carRentalPlan,
-            parkRidePlan: result.parkRidePlan,
+            parkRidePlan,
             onDemandTaxiPlan: result.onDemandTaxiPlan,
           },
           () => {

diff --git a/app/component/StreetModeSelector.js b/app/component/StreetModeSelector.js
@@ -51,9 +51,10 @@ export const StreetModeSelector = ({
           ...(bikeParkPlan?.itineraries || []),
           ...(bikeAndPublicPlan?.itineraries || []),
           ...(bikeRentAndPublicPlan?.itineraries || []),
-        ],
+        ].filter(itinerary => itinerary.legs.some(l => l.transitLeg)),
       }
     : {};
+
   const carRentalOrOwn = !loading
     ? {
         itineraries: [