Skip to content

Conversation

@brice-stacks
Copy link
Contributor

These should eventually switch over to using the Rust-native k256 crate from RustCrypto, but for now, we are reverting this to allow more time to ensure there are no accidental consensus breaking changes.

Replaces #6644 for now.

These should eventually switch over to using the Rust-native `k256`
crate from RustCrypto, but for now, we are reverting this to allow more
time to ensure there are no accidental consensus breaking changes.
aaronb-stacks
aaronb-stacks previously approved these changes Oct 31, 2025
Copy link
Contributor

@aaronb-stacks aaronb-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just checked for an exact match of the prior code:

 % git diff -r release/3.2.0.0.2 HEAD stacks-common/Cargo.toml
diff --git a/stacks-common/Cargo.toml b/stacks-common/Cargo.toml
index 8adaa41eee..b9944732c9 100644
--- a/stacks-common/Cargo.toml
+++ b/stacks-common/Cargo.toml
@@ -42,6 +42,10 @@ serde_json = { workspace = true }
 sha3 = { version = "0.10.1", default-features = false }
 slog = { workspace = true }
 slog-term = { version = "2.6.0", default-features = false }
+thiserror = { workspace = true }
+
+# RustCrypto elliptic curve crates
+p256 = { version = "0.13", default-features = false, features = ["std", "serde", "ecdsa"] }
 
 # Optional dependencies
 getrandom = { version = "0.2", default-features = false, optional = true }
% git diff -r release/3.2.0.0.2 HEAD stacks-common/src/util/secp256k1  
% git diff -r release/3.2.0.0.2 HEAD stacks-common/src/util/mod.rs   
diff --git a/stacks-common/src/util/mod.rs b/stacks-common/src/util/mod.rs
index 69e14a4473..25be66f146 100644
--- a/stacks-common/src/util/mod.rs
+++ b/stacks-common/src/util/mod.rs
@@ -27,6 +27,7 @@ pub mod pair;
 pub mod pipe;
 pub mod retry;
 pub mod secp256k1;
+pub mod secp256r1;
 pub mod serde_serializers;
 pub mod uint;
 pub mod vrf;

And it looks good to me!

aaronb-stacks
aaronb-stacks previously approved these changes Oct 31, 2025
jcnelson
jcnelson previously approved these changes Oct 31, 2025
@brice-stacks brice-stacks added this pull request to the merge queue Oct 31, 2025
Merged via the queue into stacks-network:develop with commit 2165fce Oct 31, 2025
304 of 308 checks passed
@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 62.03320% with 183 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.90%. Comparing base (f8d02cd) to head (ebef1e3).
⚠️ Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
stacks-common/src/util/secp256k1/native.rs 61.25% 179 Missing ⚠️
stacks-common/src/util/secp256k1/mod.rs 0.00% 3 Missing ⚠️
stacks-common/src/util/pipe.rs 0.00% 1 Missing ⚠️

❌ Your project status has failed because the head coverage (62.90%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (f8d02cd) and HEAD (ebef1e3). Click for more details.

HEAD has 50 uploads less than BASE
Flag BASE (f8d02cd) HEAD (ebef1e3)
121 71
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6645       +/-   ##
============================================
- Coverage    74.67%   62.90%   -11.77%     
============================================
  Files          574      575        +1     
  Lines       355039   354908      -131     
============================================
- Hits        265114   223269    -41845     
- Misses       89925   131639    +41714     
Files with missing lines Coverage Δ
stacks-common/src/types/mod.rs 79.49% <ø> (-2.13%) ⬇️
stacks-signer/src/signerdb.rs 68.03% <100.00%> (-15.83%) ⬇️
stacks-common/src/util/pipe.rs 61.98% <0.00%> (-13.76%) ⬇️
stacks-common/src/util/secp256k1/mod.rs 0.00% <0.00%> (ø)
stacks-common/src/util/secp256k1/native.rs 61.25% <61.25%> (ø)

... and 401 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8d02cd...ebef1e3. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

github-actions bot commented Nov 8, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot added the locked label Nov 8, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants