chore: add consensus tests for MemoryBalanceExceeded
#6642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francesco-stacks
added
aac
francesco-stacks
requested review from
aaronb-stacks,
federico-stacks and
jacinta-stacks
francesco-stacks
changed the title
MemoryExceededErrorMemoryBalanceExceeded
jacinta-stacks
approved these changes
Oct 30, 2025
| /// - 20 transactions that call the contract (should fail with MemoryBalanceExceeded) | ||
| /// - 1 transaction that is expected to succeed | ||
| #[test] | ||
| fn test_memory_balance_exceeded_multiple_calls() { |
Contributor
There was a problem hiding this comment.
qq: shouldn't we rely on insta for all the consensus test?
Author
There was a problem hiding this comment.
Yeah, the idea is that this in particular is not meant to be a consensus test but a more classic "integration test", I just used the new framework for it. But good thing you brought it up because this doesn't belong in here.
When we are going to merge your PR that makes the symbols public and ready to be used in other files, I'll move it somewhere else.
|
|
||
| // Tests that `MemoryBalanceExceeded` error occurs during a contract call. | ||
| // The transaction will fail but will still be committed to the block. | ||
|
|
Contributor
There was a problem hiding this comment.
Nit. Should remove this empty line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applicable issues
Additional info (benefits, drawbacks, caveats)
Checklist
docs/rpc/openapi.yamlandrpc-endpoints.mdfor v2 endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepo