-
Notifications
You must be signed in to change notification settings - Fork 696
chore: enhance config docs #6168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enhance config docs #6168
Conversation
@Jiloc really good start - i don't envy what you did here, just reading through it was no small task due to the nature of these changes, and as much as i would like to say "let's break this up into several PR's" - that would not be ideal here. overall, i like the proposed changes - there are a few nits and i think we should define the syntax a little better, possibly adding some more fields to the proposed syntax vs keeping them as normal comment lines. it almost looks like i would also like to hear about how these changes will help with parsing/extracting/rendering these comments to some output that can be consumed. for example, if there is a process or tool in mind, that could help inform what the syntax should look like globally. edit: several of my comments above can be applied throughout the diff, but to reduce noise and repeating myself i've only marked a few examples where i think a change would be appropriate, with the expectation that later instances would use the same changes/rules. |
thanks! i think the syntax definition is fine to leave in #6171 in light of that, i'll check and resolve some existing comments here that may now be answered with that def. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgmt!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6168 +/- ##
===========================================
+ Coverage 77.27% 83.60% +6.32%
===========================================
Files 545 545
Lines 392359 392359
Branches 323 323
===========================================
+ Hits 303184 328017 +24833
+ Misses 89167 64334 -24833
Partials 8 8
... and 203 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
This PR contains only formatting changes to the doc comments. The goal is to simplify the format to make it easier to programmatically extract and parse.
Applicable issues
Checklist
docs/rpc/openapi.yaml
andrpc-endpoints.md
for v2 endpoints,event-dispatcher.md
for new events)clarity-benchmarking
repobitcoin-tests.yml