-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-28098: explicitly set advisory #14284
base: master
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
Images are ready for the commit at a08c71a. To use with deploy scripts, first |
Postgres tests are failing because we are not writing the advisory to the table. Due to the data model changes, I don't know the best place to put this (CVE, ImageCVE, ImageCVEV2?) Can someone from @stackrox/core-workflows let me know where to put it? |
// advisory returns the vulnerability's related advisory. | ||
// | ||
// Only Red Hat advisories (RHSA/RHBA/RHEA) are supported at this time. | ||
func advisory(vuln *claircore.Vulnerability) string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@crozzy can you confirm we can/should fetch the advisory from the links?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no API guarantee for the format/contents of the links field, having said that:
- I don't think there is any other way to tie them together without pulling the VEX CVE file and looking it up yourself.
- There is no plans to change the format until the Matcher v2 schema changes are updated that should render hacks like this moot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me. Seems like this is the best way to do this using Claircore's native data
IMO, go to the image store test and add something like what I did in #13682. You can even reference the same ticket if you want and I'll deal with it soon. Minimizes the interference of proto churn and keeps your PR focused.
We are going to have to create a new version of that store and test anyway so there is no real point on spending much thought on it for the scanner side of the changes. |
@RTann: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Central DB's image and CVE data models are going through a metamorphosis now, and this will help. The goal is to show CVEs along with their associated advisory, if applicable, which this PR enables.
Note: this currently only affects Red Hat vulnerability data, and not GHSAs, DSAs, ALAS, etc. The current goal is to just do this for Red Hat data, at this time.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
CI