ROX-25508: migrate collector pipeline to matrix builds #2634
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2634 +/- ##
=======================================
Coverage 27.60% 27.60%
=======================================
Files 95 95
Lines 5422 5422
Branches 2523 2523
=======================================
Hits 1497 1497
Misses 3213 3213
Partials 712 712
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| type: array | ||
| description: Additional labels to put on the built containers. | ||
| - default: | ||
| - linux-c2xlarge/amd64 |
There was a problem hiding this comment.
Looking at the build time, linux-c2xlarge/amd64 is a reasonable choice, though I wonder if linux-cxlarge/amd64 would do just as well. Do you mind running a build with it to see if the build duration remains the same?
There was a problem hiding this comment.
I'll try. With linux-c2xlarge the build time was between 23-25 minutes (for amd64 and arm64).
There was a problem hiding this comment.
one datapoint: the build time was approx 10 minutes slower: https://konflux-ui.apps.stone-prd-rh01.pg1f.p1.openshiftapps.com/ns/rh-acs-tenant/applications/acs/pipelineruns/collector-on-push-58wtk
There was a problem hiding this comment.
Seems like times vary wildly. PPC is the fastest today. I triggered another rebuild.
https://konflux-ui.apps.stone-prd-rh01.pg1f.p1.openshiftapps.com/ns/rh-acs-tenant/applications/acs/pipelineruns/collector-on-push-sxhjd
3 participants
Description
Applied the changes established in stackrox/stackrox#17517 to the collector pipelines.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
Konflux testing sufficient.