Skip to content

Add Spin framework adapter#58

Open
ChristianPavilonis wants to merge 3 commits intomainfrom
feature/spin
Open

Add Spin framework adapter#58
ChristianPavilonis wants to merge 3 commits intomainfrom
feature/spin

Conversation

@ChristianPavilonis
Copy link
Copy Markdown
Contributor

@ChristianPavilonis ChristianPavilonis commented Feb 18, 2026

Summary

  • Add a new mocktioneer-adapter-spin crate so Mocktioneer can run on the Fermyon Spin platform via WASI.
  • Register the Spin adapter across all existing HTTP trigger routes in edgezero.toml.
  • Ignore Spin runtime log directories in .gitignore.

Changes

Crate / File Change
crates/mocktioneer-adapter-spin/Cargo.toml New crate manifest with cdylib target, spin feature, and WASM-only deps
crates/mocktioneer-adapter-spin/src/lib.rs Spin HTTP component entrypoint delegating to edgezero_adapter_spin::run_app
crates/mocktioneer-adapter-spin/spin.toml Spin manifest (catch-all route, WASM source, outbound hosts, build config)
edgezero.toml Added "spin" to every route's adapters list; added [adapters.spin] section with build/serve/deploy commands
.gitignore Ignore .spin/logs/ directories

Test plan

  • cargo test --workspace --all-targets
  • cargo clippy --workspace --all-targets --all-features -- -D warnings
  • cargo check --workspace --all-targets --features "fastly cloudflare"

Checklist

  • Changes follow CLAUDE.md conventions
  • Business logic lives in mocktioneer-core, not in adapter crates
  • New routes added to both routes.rs and edgezero.toml
  • Determinism preserved — no randomness or time-dependent logic
  • No secrets or credentials committed

@ChristianPavilonis ChristianPavilonis marked this pull request as ready for review March 12, 2026 19:08
@ChristianPavilonis ChristianPavilonis marked this pull request as draft March 12, 2026 19:09
@ChristianPavilonis ChristianPavilonis marked this pull request as ready for review March 31, 2026 15:01
@ChristianPavilonis ChristianPavilonis changed the title Support for spin framework Add Spin framework adapter Mar 31, 2026
Copy link
Copy Markdown
Contributor

@aram356 aram356 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review

Summary

The PR adds a Spin framework adapter following the existing adapter pattern. The adapter code itself is clean and minimal, but there are fundamental workspace integration issues that prevent the crate from building or being validated by CI.

Findings

🔧 Needs Change

  • Crate not in workspace members: crates/mocktioneer-adapter-spin is not listed in [workspace].members in root Cargo.toml. All CI gates (test, clippy, fmt) pass only because cargo doesn't know this crate exists — it is never compiled, tested, or linted.
  • Missing workspace dependencies: edgezero-adapter-spin and spin-sdk are referenced as workspace = true but not declared in [workspace.dependencies]. Hard build failure once the crate is added to workspace members.
  • Duplicate dependency with conflicting features: edgezero-adapter-spin appears in both [dependencies] and [target.wasm32.dependencies] with different feature specs. See inline comment for details.
  • Missing license.workspace = true: Inconsistent with Fastly and Cloudflare adapters.
  • Empty crate on host target: All code is #[cfg(target_arch = "wasm32")], leaving an empty lib for host builds.

❓ Questions

  • Does edgezero-adapter-spin exist upstream? It's not in Cargo.lock or workspace deps. If the edgezero framework doesn't have Spin support yet, this PR is premature.
  • Spin 2 vs Spin 3? spin_manifest_version = 2 + wasm32-wasip1 = Spin 2.x. Spin 3.x uses WASI Preview 2. Which is targeted?

🤔 Thoughts

  • spin.toml build command missing -p flag: Will try to build entire workspace for WASM, which will fail (Axum can't compile to WASM).

⛏ Nitpicks

  • Missing echo_stdout in spin adapter logging (edgezero.toml): Other adapters explicitly set this. Minor inconsistency.

🌱 Seeds

  • CI feature check: Once merged, cargo check --features "fastly cloudflare" should become --features "fastly cloudflare spin".

👍 Praise

  • Clean route registration: All existing routes correctly updated with "spin" in the adapters array. No routes missed.
  • Adapter stays thin: 12 lines delegating to edgezero_adapter_spin::run_app. Exactly the right pattern.

CI Status

  • fmt: PASS (but spin crate not checked — not in workspace)
  • clippy: PASS (but spin crate not checked — not in workspace)
  • tests: PASS (but spin crate not compiled — not in workspace)

- Add mocktioneer-adapter-spin to workspace members
- Add edgezero-adapter-spin and spin-sdk to workspace dependencies
- Add license.workspace = true to adapter Cargo.toml
- Fix duplicate edgezero-adapter-spin dependency, set default = []
- Add module doc and cfg_attr for non-WASM host compilation
- Update to Spin 3: manifest v3, wasm32-wasip2 target, spin-sdk 5.2
- Add -p flag to spin.toml and edgezero.toml build commands
- Update CI feature check to include spin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants