Apply network permissions from registry #1041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove the default "network" value from the CLI - Consolidate override logic into a single function - Default to "network" permissions only if there is no permission profile set and there is no default profile in the registry Fix #1008
eleftherias
force-pushed
the
fix-network-isolation-default
branch
from
c32f08a to
a42173e
Compare
|
@danbarr Could you give this a try? I tested it with:
|
|
@eleftherias This is working great! I ran a few tests, including some servers like |
JAORMX
approved these changes
Jul 11, 2025
rvarun11
pushed a commit
to rvarun11/toolhive
that referenced
this pull request
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1008