This repository was archived by the owner on Jul 8, 2025. It is now read-only.
fix(alerts-table): trigger token box and copy to clipboard icon#85
Merged
Conversation
alex-mcgovern
previously approved these changes
Jan 16, 2025
Collaborator
Pull Request Test Coverage Report for Build 12807178728Details
💛 - Coveralls |
| await userEvent.type(screen.getByRole("searchbox"), "codegate-secrets"); | ||
|
|
||
| await waitFor(() => | ||
| waitFor(() => |
Contributor
There was a problem hiding this comment.
We need to await the promise returned by waitFor, as it can continue to run after the test has exited, and we may miss the result assertions that are happening within it
| await userEvent.type(screen.getByRole("searchbox"), "codegate-secrets"); | ||
|
|
||
| await waitFor(() => | ||
| waitFor(() => |
Contributor
There was a problem hiding this comment.
Suggested change
| waitFor(() => | |
| await waitFor(() => |
alex-mcgovern
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEFORE
AFTER
Fix trigger token spacing
