feat: implement new table design #189
Conversation
Pull Request Test Coverage Report for Build 12988563640Details
💛 - Coveralls |
kantord
force-pushed
the
alerts-table-refactor
branch
from
89a78e7 to
f22e138
Compare
kantord
force-pushed
the
alerts-table-refactor
branch
from
f22e138 to
f7c9c73
Compare
kantord
force-pushed
the
alerts-table-refactor
branch
from
1931241 to
7d55f72
Compare
| const maliciousPackage = getMaliciousPackage(alert.trigger_string); | ||
|
|
||
| if (maliciousPackage !== null && typeof maliciousPackage === "object") { | ||
| return "malicious_package"; |
There was a problem hiding this comment.
for malicious package we can show the link to insights, it was already in place, I guess it could be very useful to show.
@jtenniswood maybe you didn't have an real example on that:
There was a problem hiding this comment.
hmm, if the entire table row is clickable, does it make sense to put another link to it?
I think that we should create an alert detail page 🤔 then we could put all these additional information there.
Actually I think that we can convert the current conversation page into an alert detail page? Basically keeping the current content but adding a header or sth similar where we can add details about the alert (I guess this could be hidden for conversations that don't have any alerts?)
There was a problem hiding this comment.
hmm, if the entire table row is clickable, does it make sense to put another link to it?
I agree, but I also see the value to show the detail about a malicious package, maybe instead of a clickable row we could add a column e.g. go to chat
I guess that James is not aware of this malicious package detail
There was a problem hiding this comment.
yes, I totally agree, I prefer that over a clickable row any day. It's much clearer user experience in my opinion
There was a problem hiding this comment.
I will mention this to James
There was a problem hiding this comment.
I wonder if that sub content should be on the sub page? I have also heard people wanting to be linked to the place where it happens in the conversation (also for secrets leaking).
This PR implements the new design for the alerts table.
There is an ongoing discussion to include all messages, not just alerts in this table and just pre-filter them to hide non-problematic sessions. This PR does not implement this idea at all, but it changes the columns of the table in a way that will prepare the ground for that change as well