Merged
Conversation
COW snapshot isolation is now active on every run, not just when --review is passed. Git credential sanitization and security-pattern exclusion run unconditionally. --review now only controls whether the user interactively approves each file change; without it an AutoAcceptReviewer auto-accepts all changes. Also fixes snapshot directory leak on non-zero agent exit by cleaning up before os.Exit. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jhrozek
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--reviewis passed.env*,*.pem,.ssh/,.git/config) run unconditionally — closes credential leak vector when--reviewwas forgotten--reviewnow only controls interactive per-file approval; without it, a newAutoAcceptReviewerauto-accepts all changes (same end result as the old direct mount, but with snapshot safety)os.ExitChanges
internal/infra/review/auto.goAutoAcceptReviewerimplementingsnapshot.Reviewerinternal/infra/review/auto_test.gocmd/bbox/main.go--review, remove credential warning, fixos.Exitleakcmd/bbox/main_test.goCLAUDE.mdTest plan
task verifypasses (fmt + lint + test with race detector)bbox claude-code— creates snapshot, auto-accepts all changesbbox claude-code --review— creates snapshot, interactive per-file reviewbbox claude-code --exclude "*.log"— exclude patterns work without--review🤖 Generated with Claude Code