Skip to content

Feature: CDN distribution resource and data source #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 29, 2025
Merged

Feature: CDN distribution resource and data source #786

merged 8 commits into from
Apr 29, 2025

Conversation

malteehrlen
Copy link
Contributor

@malteehrlen malteehrlen commented Apr 22, 2025 •
edited
Loading

Description

  • Add terraform data source and resource for STACKIT CDN distributions

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@rubenhoenle
Copy link
Member

@malteehrlen As said in the PR template, please link an GitHub issue or at least add a description which describes what you want to achieve within your PR.

@malteehrlen malteehrlen force-pushed the cdn/me/distribution_resource branch 4 times, most recently from 5e6d900 to bc7c08b Compare April 25, 2025 13:00
@malteehrlen malteehrlen changed the title Cdn/me/distribution resource Feature: CDN distribution resource and data source Apr 25, 2025
@malteehrlen malteehrlen force-pushed the cdn/me/distribution_resource branch 3 times, most recently from e534c17 to 47e290c Compare April 25, 2025 13:15
@malteehrlen malteehrlen force-pushed the cdn/me/distribution_resource branch from 47e290c to 4a2267f Compare April 25, 2025 13:20
@malteehrlen malteehrlen marked this pull request as ready for review April 25, 2025 13:24
@malteehrlen
Copy link
Contributor Author

@rubenhoenle I have now published the PR for review, please have a look.

h3adex
h3adex reviewed Apr 25, 2025
View reviewed changes
@malteehrlen malteehrlen force-pushed the cdn/me/distribution_resource branch 2 times, most recently from 36538a5 to c1e165e Compare April 25, 2025 15:46
@malteehrlen malteehrlen force-pushed the cdn/me/distribution_resource branch from c1e165e to 598d404 Compare April 28, 2025 12:33
@malteehrlen malteehrlen force-pushed the cdn/me/distribution_resource branch from 598d404 to 452ec0c Compare April 28, 2025 12:37
@malteehrlen malteehrlen force-pushed the cdn/me/distribution_resource branch from 510ab6a to a5c3c0f Compare April 29, 2025 13:55
@bahkauv70 bahkauv70 merged commit 855d304 into stackitcloud:main Apr 29, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h3adex h3adex h3adex left review comments

@bahkauv70 bahkauv70 bahkauv70 approved these changes

@marceljk marceljk Awaiting requested review from marceljk marceljk is a code owner

@Fyusel Fyusel Awaiting requested review from Fyusel Fyusel is a code owner

@rubenhoenle rubenhoenle Awaiting requested review from rubenhoenle rubenhoenle is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@malteehrlen @rubenhoenle @h3adex @bahkauv70 @malte-ehrlen