refac(mariadb): Use new WaitHelper for waiters#7278
Open
Fyusel wants to merge 1 commit into
Open
Conversation
Fyusel
force-pushed
the
mariadb-refac-waithandler
branch
from
a3732ec to
3fc46c3
Compare
Fyusel
changed the title
Fyusel
force-pushed
the
mariadb-refac-waithandler
branch
2 times, most recently
from
c183494 to
1ab0465
Compare
cgoetz-inovex
previously approved these changes
May 18, 2026
Comment on lines
-80
to
-81
| if strings.Contains(s.LastOperation.Description, "DeleteFailed") || strings.Contains(s.LastOperation.Description, "failed") { | ||
| return true, nil, fmt.Errorf("instance was deleted successfully but has errors: %s", s.LastOperation.Description) |
Contributor
There was a problem hiding this comment.
should we keep this behaviour?
Contributor
Author
There was a problem hiding this comment.
Yes, we should keep it in my opinion. Thanks! Saw that in my other PR but forgot this here 🙈
Fyusel
force-pushed
the
mariadb-refac-waithandler
branch
2 times, most recently
from
3226d1c to
605ae16
Compare
STACKITSDK-380 Signed-off-by: Alexander Dahmen <alexander.dahmen@inovex.de>
Fyusel
force-pushed
the
mariadb-refac-waithandler
branch
from
605ae16 to
5898798
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STACKITSDK-380
Description
Checklist
make fmtexamples/directory)make test(will be checked by CI)make lint(will be checked by CI)