Onboard Logs service -instance commands #1184
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging this branch changes the coverage (1 decrease, 8 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
rubenhoenle
reviewed
Dec 17, 2025
| if model.Async { | ||
| operationState = "Triggered deletion of" | ||
| } | ||
| params.Printer.Info("%s instance %q\n", operationState, instanceLabel) |
Member
There was a problem hiding this comment.
Suggested change
| params.Printer.Info("%s instance %q\n", operationState, instanceLabel) | |
| params.Printer.Outputf("%s instance %q\n", operationState, instanceLabel) |
printer.Info goes to stderr, printer.Outputf goes to stdout 😉
rubenhoenle
reviewed
Dec 17, 2025
| { | ||
| name: "empty instance in instances slice", | ||
| args: args{ | ||
| instances: []logs.LogsInstance{}, |
Member
There was a problem hiding this comment.
Suggested change
| instances: []logs.LogsInstance{}, | |
| instances: []logs.LogsInstance{{}}, |
you have to add an empty instance, currently this is just an empty slice 😄
rubenhoenle
reviewed
Dec 17, 2025
|
|
||
| table := tables.NewTable() | ||
| table.SetHeader("NAME", "ID", "STATUS") | ||
| for i := range instances { |
Member
There was a problem hiding this comment.
Suggested change
| for i := range instances { | |
| for _, instance := range instances { |
Saves yourself the next line (instance := instances[i])...
rubenhoenle
reviewed
Dec 17, 2025
| instance := instances[i] | ||
|
|
||
| instanceStatus := "" | ||
| if instance.Status != nil { |
Member
There was a problem hiding this comment.
No need to do this check here, the utils.PtrString func handles that case for you
stackit-cli/internal/pkg/utils/utils.go
Lines 24 to 31 in 9660efb
rubenhoenle
reviewed
Dec 17, 2025
| return req | ||
| } | ||
|
|
||
| func outputResult(p *print.Printer, model *inputModel, projectLabel string, instance *logs.LogsInstance) error { |
Member
There was a problem hiding this comment.
No unit tests for that one? 😞
rubenhoenle
reviewed
Dec 17, 2025
| if err != nil { | ||
| return "", fmt.Errorf("get Logs instance: %w", err) | ||
| } | ||
| return *resp.DisplayName, nil |
Member
There was a problem hiding this comment.
Potential nil pointer dereference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to STACKITCLI-292
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)