Skip to content

Conversation

priteau
Copy link
Member

@priteau priteau commented Sep 9, 2025

Disable Trivy telemetry and version check introduced in v0.63.0.

@priteau priteau self-assigned this Sep 9, 2025
@priteau priteau requested a review from a team as a code owner September 9, 2025 13:43
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @priteau, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the version of Trivy used in the image scanning script and configures it to disable its telemetry and version check functionalities. The primary goal is to leverage the latest features and fixes from the newer Trivy version while ensuring privacy and avoiding unnecessary external communication during scans.

Highlights

  • Trivy Version Bump: The Trivy version used and recommended for installation has been updated from v0.62.1 to v0.66.0.
  • Telemetry and Version Check Disabled: Trivy's telemetry and version check features are now explicitly disabled within the scan script to prevent unwanted network calls.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the Trivy version to v0.66.0 and disables telemetry as intended. The changes are functional. I've added a couple of suggestions to improve the script's maintainability by defining the Trivy version as a variable, which will make future updates simpler.

@Alex-Welsh
Copy link
Member

Classic Gemini mild scope creep

Copy link
Member

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, up to you whether you apply Gemini's suggestions

@priteau priteau merged commit 17080e1 into stackhpc/2025.1 Sep 9, 2025
25 of 28 checks passed
@priteau priteau deleted the bump-trivy branch September 9, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants