Skip to content

Add issues experienced during test upgrade #1822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: stackhpc/2025.1
Choose a base branch
from

Conversation

seunghun1ee
Copy link
Member

From SMS Lab upgrade

Copy link
Member

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor grammar nitpicks

Comment on lines +210 to +214
`Let's Encrypt TLS settings fix <https://review.opendev.org/c/openstack/kolla-ansible/+/925971>`__
brought breaking change to Let’s Encrypt ansible role. Now users have to explictly set the target
Let’s Encrypt ACME server as a kolla ansible variable ``letsencrypt_external_cert_server``/
``letsencrypt_internal_cert_server`` if they were using Let’s Encrypt as a CA of their
external/internal TLS certificates.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`Let's Encrypt TLS settings fix <https://review.opendev.org/c/openstack/kolla-ansible/+/925971>`__
brought breaking change to Let’s Encrypt ansible role. Now users have to explictly set the target
Let’s Encrypt ACME server as a kolla ansible variable ``letsencrypt_external_cert_server``/
``letsencrypt_internal_cert_server`` if they were using Let’s Encrypt as a CA of their
external/internal TLS certificates.
`Let's Encrypt TLS settings fix <https://review.opendev.org/c/openstack/kolla-ansible/+/925971>`__
brought a breaking change to Let’s Encrypt ansible role. Now users have to explicitly set the target
Let’s Encrypt ACME server as a kolla ansible variable ``letsencrypt_external_cert_server``/
``letsencrypt_internal_cert_server`` if they were using Let’s Encrypt as a CA of their
external/internal TLS certificates.

Comment on lines +219 to +224
`Enhancement of Ceph integration of multiple clusters
<https://review.opendev.org/c/openstack/kolla-ansible/+/907166>`__
made Cinder role now requires ``user`` and ``pool`` set to the each item of kolla dict
variable ``cinder_ceph_backends`` at ``$KAYOBE_CONFIG_PATH/kolla/globals.yml``
(``$KAYOBE_CONFIG_PATH/environments/<env>/kolla/globals.yml`` if using environments)
For example,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`Enhancement of Ceph integration of multiple clusters
<https://review.opendev.org/c/openstack/kolla-ansible/+/907166>`__
made Cinder role now requires ``user`` and ``pool`` set to the each item of kolla dict
variable ``cinder_ceph_backends`` at ``$KAYOBE_CONFIG_PATH/kolla/globals.yml``
(``$KAYOBE_CONFIG_PATH/environments/<env>/kolla/globals.yml`` if using environments)
For example,
`Enhancement of Ceph integration of multiple clusters
<https://review.opendev.org/c/openstack/kolla-ansible/+/907166>`__
means the Cinder role now requires ``user`` and ``pool`` set to the each item of kolla dict
variable ``cinder_ceph_backends`` at ``$KAYOBE_CONFIG_PATH/kolla/globals.yml``
(``$KAYOBE_CONFIG_PATH/environments/<env>/kolla/globals.yml`` if using environments)
For example,

pool: volumes-hdd
enabled: true

You can find the name of pools from ``cephadm_pools`` in cephadm.yml.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about user?


You can find the name of pools from ``cephadm_pools`` in cephadm.yml.

The K-A upstream change `<https://review.opendev.org/c/openstack/kolla-ansible/+/909974>`__
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be best to shorten this

Suggested change
The K-A upstream change `<https://review.opendev.org/c/openstack/kolla-ansible/+/909974>`__
The K-A upstream change `#909974 <https://review.opendev.org/c/openstack/kolla-ansible/+/909974>`__

The K-A upstream change `<https://review.opendev.org/c/openstack/kolla-ansible/+/909974>`__
requires users to manually set Cinder cluster name at ``$KAYOBE_CONFIG_PATH/kolla/globals.yml``
(``$KAYOBE_CONFIG_PATH/environments/<env>/kolla/globals.yml`` if using environments).
It should be matching with current cluster name. You can find the name from ``cinder.conf``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure that this is the correct variable, but we should definitely include the variable name here.

Suggested change
It should be matching with current cluster name. You can find the name from ``cinder.conf``.
It should match the current cluster name. You can find the name from ``cinder.conf`` as ``rbd_cluster_name``.

Comment on lines +254 to +257
Elasticseach storage driver is no longer compatible with Opensearch storage backend.
Need to set CloudKitty storage backend to Opensearch if it was set to be Elasticseach before.
This can be set at ``$KAYOBE_CONFIG_PATH/kolla/globals.yml``
(``$KAYOBE_CONFIG_PATH/environments/<env>/kolla/globals.yml`` if using environments)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Elasticseach storage driver is no longer compatible with Opensearch storage backend.
Need to set CloudKitty storage backend to Opensearch if it was set to be Elasticseach before.
This can be set at ``$KAYOBE_CONFIG_PATH/kolla/globals.yml``
(``$KAYOBE_CONFIG_PATH/environments/<env>/kolla/globals.yml`` if using environments)
The elasticsearch storage driver is no longer compatible with Opensearch storage backend.
Set the CloudKitty storage backend to ``opensearch`` if it was ``elasticseach`` before.
This can be set at ``$KAYOBE_CONFIG_PATH/kolla/globals.yml``
(``$KAYOBE_CONFIG_PATH/environments/<env>/kolla/globals.yml`` if using environments)

From Dalmatian, `Kayobe no longer provides its own default driver & interfaces
<https://review.opendev.org/c/openstack/kayobe/+/836999>`__
for Ironic and follows Ironic's default.
This can cause your Ironic configuration ``ironic.conf`` to have regression.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This can cause your Ironic configuration ``ironic.conf`` to have regression.
This can cause your Ironic configuration ``ironic.conf`` to regress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size: m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants