-
Notifications
You must be signed in to change notification settings - Fork 23
Add reminder to remove custom blackbox endpoints #1515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
76a896f
to
800dfe6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is coming in Epoxy, not Caracal, and I don't think we need the warning anyway. prometheus_blackbox_exporter_endpoints
has been removed from the master branch already, so when we merge stackhpc/2025.1 to do the upgrades, it'll get removed automatically
Though it won't be removed from a |
@technowhizz can you update this to target |
800dfe6
to
5a3e0b5
Compare
@technowhizz I'd like to get this wrapped up soon since the epoxy release isn't far away. Can you respond to the comments & resolve the merge conflict? |
5a3e0b5
to
0e12723
Compare
0e12723
to
791410e
Compare
@technowhizz I've added a suggestion, could you review please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
86cd3c3
to
381b4f3
Compare
No description provided.