fix: Nested new comments are not highlighted #2133
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efactor ViewAllReplies and ReplyOnAnotherPage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2127
Tracks variances of
ncommentson a comment that has at least 7 items in its path, meaning it could be a thread with nested comments.It accesses the cache to gather the latest
ncommentsScreenshots
tbd
Additional Context
It also merges
ViewAllReplieswithReplyOnAnotherPagesince they share the same logic and design and would have had duplicate code for comment highlighting.Checklist
Are your changes backwards compatible? Please answer below:
Yes, logic is the same for anything else
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
5, tbd testing
For frontend changes: Tested on mobile, light and dark mode? Please answer below:
Did you introduce any new environment variables? If so, call them out explicitly here: