Skip to content

fix: url search #2083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2025
Merged

fix: url search #2083

merged 3 commits into from
Apr 15, 2025

Conversation

abhiShandy
Copy link
Member

@abhiShandy abhiShandy commented Apr 8, 2025

Description

A clear and concise description of what you changed and why.

Updated the Opensearch query for URLs with a match query

fixes #1270

Screenshots

Before:

Screenshot 2025-04-08 at 6 08 01 PM

After:

Screenshot 2025-04-08 at 6 06 26 PM

Additional Context

Was anything unclear during your work on this PR? Anything we should definitely take a closer look at?

Checklist

Are your changes backwards compatible? Please answer below:

Yes, I did not remove any query.

On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:

For frontend changes: Tested on mobile, light and dark mode? Please answer below:
N/A

Did you introduce any new environment variables? If so, call them out explicitly here:
N/A

@abhiShandy abhiShandy marked this pull request as ready for review April 8, 2025 23:11
Copy link
Member

@ekzyis ekzyis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

The change makes sense to me but I didn't test and I don't know much about our search. I'll update my review when I know more.

@huumn
Copy link
Member

huumn commented Apr 9, 2025

This seems to indicate that the wildcard query does not work on the url field. I'll try to QA this by early next week.

@huumn huumn merged commit 66dbf24 into stackernews:master Apr 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search using URL: not finding Twitter link
3 participants