Skip to content

show sats on full view pinned comments #2071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2025

Conversation

Soxasora
Copy link
Member

@Soxasora Soxasora commented Apr 6, 2025

Description

Fixes #1475
Shows sats value for pinned comments in full view (reply on another page).
If your own Item is pinned, it shows Pin instead of Boost icon on comment view

Screenshots

Comment view
image

Full view
image

Additional Context

Simplified condition readability
This is a simple fix but for UX reasons we might want to evaluate the possibility of showing the Zap button for pinned comments along with a pinned icon, like this:
image

Checklist

Are your changes backwards compatible? Please answer below:
Yes

On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
6, tested on pinned comments that belongs to an Item that belongs to a territory; also tested on pinned comments on pinned posts without a territory.

For frontend changes: Tested on mobile, light and dark mode? Please answer below:
n/a

Did you introduce any new environment variables? If so, call them out explicitly here:
n/a

@Soxasora Soxasora added the ui/ux label Apr 7, 2025
@Soxasora Soxasora marked this pull request as ready for review April 11, 2025 20:40
@huumn
Copy link
Member

huumn commented Apr 15, 2025

I'm sure it's just some small issue but I don't see the pin if I pin my comment on my own item.

Screenshot 2025-04-14 at 7 46 22 PM

Then if I visit the item directly (ie "full") then the lightning bolt is hidden.

Screenshot 2025-04-14 at 7 46 34 PM

It might've been buggy like this before. idk. But we probably want to fix that.

@Soxasora
Copy link
Member Author

Soxasora commented Apr 15, 2025

I don't see the pin if I pin my comment on my own item.

Ah yes, that's the standard behavior, I'll push something for that ^^

Then if I visit the item directly (ie "full") then the lightning bolt is hidden.

Weird, this doesn't happen to me
image

I think that the only case in which we don't show something there, is when we want to hide the boost icon for biographies

: item.mine || item.meForward
    ? <Boost item={item} className={classNames(styles.upvote, item.bio && 'invisible')} />

And we show boost icon only on own items (but we're on anon)
Hmm, I'll investigate

@huumn huumn merged commit 22e4f8a into stackernews:master Apr 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comment has been zapped but does not show number of sats have been zapped
2 participants