Skip to content

fix: Images on iOS are cropped weird #1840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 28, 2025
Merged

fix: Images on iOS are cropped weird #1840

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
05b8093
force sync decoding on images
Soxasora Jan 22, 2025
fcdf262
use decode() to load the image
Soxasora Jan 22, 2025
11ee5ed
add comment
Soxasora Jan 22, 2025
3d8a43b
Merge branch 'master' into ios_miscropped_images
Soxasora Jan 28, 2025
ba42e59
Merge branch 'master' into ios_miscropped_images
Soxasora Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion components/media-or-link.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,12 @@ export const useMediaHelper = ({ src, srcSet: srcSetIntital, topLevel, tab }) =>
// hack
// if it's not a video it will throw an error, so we can assume it's an image
const img = new window.Image()
img.onload = () => setIsImage(true)
img.src = src
img.decode().then(() => {
setIsImage(true)
}).catch((e) => {
console.error('Cannot decode image', e)
})
}
video.src = src

Expand Down
Loading