-
Notifications
You must be signed in to change notification settings - Fork 6
ci(GHC): Drop GHC version 8 and add 9.6, 9.8, 9.10 as supported #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
davidnbr
wants to merge
7
commits into
main
Choose a base branch
from
db/bump_ghc_version_support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
346d036
ci(GHC): Drop GHC version 8 and add 9.6, 9.8, 9.10, 9.12 as supported
davidnbr 76959ae
fix: hpack build
davidnbr 3b50a20
fix(text): bump dependency constraint to fix compiling error
davidnbr 17f4feb
bump: include only 9.6, 9.8 and 9.10 GHC versions
davidnbr ecb7ec1
fix: add undeclared bytestring dependency
davidnbr 24e6ad5
bump: delete upper-bound constraint for wai-extra dependency
davidnbr ee38646
fix: add upper-bound constraint for mayor version in wai-extra
davidnbr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ license: MIT | |
| author: "Stack Builders Inc." | ||
| maintainer: "David Mazarro <[email protected]>" | ||
| copyright: "2020-present Stack Builders Inc." | ||
| tested-with: GHC ==8.8.4, GHC ==8.10.7, GHC ==9.4.7 | ||
| tested-with: GHC ==9.6.7, GHC ==9.8.4, GHC ==9.10.1 | ||
|
|
||
| extra-source-files: | ||
| - README.md | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ license: MIT | |
| author: "Stack Builders Inc." | ||
| maintainer: "David Mazarro <[email protected]>" | ||
| copyright: "2020-present Stack Builders Inc." | ||
| tested-with: GHC ==8.8.4, GHC ==8.10.7, GHC ==9.4.7 | ||
| tested-with: GHC ==9.6.7, GHC ==9.8.4, GHC ==9.10.1 | ||
|
|
||
| extra-source-files: | ||
| - README.md | ||
|
|
@@ -45,7 +45,7 @@ library: | |
| - mtl >= 2.2 && < 3 | ||
| - process >= 1.6 && < 2 | ||
| - req >= 2.1 && < 4 | ||
| - text >= 1.2 && < 2.1 | ||
| - text >= 1.2 && < 2.2 | ||
| - unordered-containers >= 0.2 && < 1 | ||
| - yaml >= 0.11 && < 1 | ||
| exposed-modules: | ||
|
|
@@ -73,6 +73,7 @@ tests: | |
| ghc-options: *exe-ghc-options | ||
| dependencies: | ||
| - aeson | ||
| - bytestring >= 0.10 && < 1 | ||
| - hspec >= 2.7 && < 3 | ||
| - mtl | ||
| - rollbar-client | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ license: MIT | |
| author: "Stack Builders Inc." | ||
| maintainer: "David Mazarro <[email protected]>" | ||
| copyright: "2020-present Stack Builders Inc." | ||
| tested-with: GHC ==8.8.4, GHC ==8.10.7, GHC ==9.4.7 | ||
| tested-with: GHC ==9.6.7, GHC ==9.8.4, GHC ==9.10.1 | ||
|
|
||
| extra-source-files: | ||
| - README.md | ||
|
|
@@ -15,7 +15,6 @@ synopsis: > | |
| Provides error reporting capabilities to WAI based applications through | ||
| Rollbar API. | ||
| category: Network | ||
|
|
||
| description: | | ||
| Please see the README on GitHub at | ||
| <https://github.com/stackbuilders/rollbar-haskell/tree/master/rollbar-wai> | ||
|
|
@@ -45,10 +44,10 @@ library: | |
| - case-insensitive >= 1.2 && < 2 | ||
| - http-types >= 0.12 && < 1 | ||
| - rollbar-client >= 1.0 && < 2 | ||
| - text >= 1.2 && < 2.1 | ||
| - text >= 1.2 && < 2.2 | ||
| - unordered-containers >= 0.2 && < 1 | ||
| - wai >= 3.2 && < 4 | ||
| - wai-extra < 3.1.17 # TODO: update breaks yesod-core, see https://github.com/yesodweb/yesod/issues/1854 | ||
| - wai-extra >=3.0 && < 4 | ||
|
|
||
| executables: | ||
| wai-example: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ license: MIT | |
| author: "Stack Builders Inc." | ||
| maintainer: "David Mazarro <[email protected]>" | ||
| copyright: "2020-present Stack Builders Inc." | ||
| tested-with: GHC ==8.8.4, GHC ==8.10.7, GHC ==9.4.7 | ||
| tested-with: GHC ==9.6.7, GHC ==9.8.4, GHC ==9.10.1 | ||
|
|
||
| extra-source-files: | ||
| - README.md | ||
|
|
@@ -16,7 +16,6 @@ synopsis: > | |
| Provides error reporting capabilities to Yesod applications through Rollbar | ||
| API. | ||
| category: Network | ||
|
|
||
| description: | | ||
| Please see the README on GitHub at | ||
| <https://github.com/stackbuilders/rollbar-haskell/tree/master/rollbar-yesod> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DavidMazarro As we are dropping support for GHC 8.x, I believe we should consider bumping the lower bound for
baseand do a major release. What do you think?We could bump to
4.15https://wiki.haskell.org/Base_package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding which versions to support, I'm wondering if we could use the following table as a reference:
@DavidMazarro Maybe we could stick with the recommended version. What do you think?
https://endoflife.date/ghc