-
Notifications
You must be signed in to change notification settings - Fork 2
feat(native): Add toHaveProp #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
kdquistanchala
wants to merge
2
commits into
feat/native-to-contain-element
Choose a base branch
from
feat/native-to-have-prop
base: feat/native-to-contain-element
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -164,6 +164,42 @@ export class ElementAssertion extends Assertion<ReactTestInstance> { | |
}); | ||
} | ||
|
||
/** | ||
* Check if the element has a specific property or a specific property value. | ||
* | ||
* @example | ||
* ``` | ||
* expect(element).toHaveProp("propName"); | ||
* expect(element).toHaveProp("propName", "propValue"); | ||
* ``` | ||
* | ||
* @param propName - The name of the prop to check for. | ||
* @param value - The value of the prop to check for. | ||
* @returns the assertion instance | ||
*/ | ||
public toHaveProp(propName: string, value?: unknown): this { | ||
const propValue: unknown = get(this.actual, `props.${propName}`, undefined); | ||
const hasProp = propValue !== undefined; | ||
const isPropEqual = value === undefined || propValue === value; | ||
|
||
const errorMessage = value === undefined | ||
? `Expected element ${this.toString()} to have prop '${propName}'.` | ||
: `Expected element ${this.toString()} to have prop '${propName}' with value '${String(value)}'.`; | ||
|
||
const invertedErrorMessage = value === undefined | ||
? `Expected element ${this.toString()} NOT to have prop '${propName}'.` | ||
: `Expected element ${this.toString()} NOT to have prop '${propName}' with value '${String(value)}'.`; | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What do you think about adding to the error message something like: Verify the element properties? |
||
const error = new AssertionError({ actual: this.actual, message: errorMessage }); | ||
const invertedError = new AssertionError({ actual: this.actual, message: invertedErrorMessage }); | ||
|
||
return this.execute({ | ||
assertWhen: hasProp && isPropEqual, | ||
error, | ||
invertedError, | ||
}); | ||
} | ||
|
||
private isElementDisabled(element: ReactTestInstance): boolean { | ||
const { type } = element; | ||
const elementType = type.toString(); | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just as for my understanding, why are we using uknown instead of undefined or any in here?