Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): correct builder path in angular.json and added the @angular-devkit/build-angular package #51

Closed
wants to merge 0 commits into from

Conversation

JeevanMahesha
Copy link
Contributor

No description provided.

@JeevanMahesha
Copy link
Contributor Author

@Nemikolh I realized I made a small mistake in my previous PR that was just merged. I caught this issue after checking on Stackblitz.com. I've already made the necessary fix and tested it locally.

Could you please review and merge the updated PR at your earliest convenience?

Copy link
Member

@Nemikolh Nemikolh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking and for the quick PR. Could you submit only the fix in this PR and have the update in a separate PR?

@@ -37,7 +37,7 @@
}
},
"serve": {
"builder": "@@angular-devkit/build-angular:dev-server",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the fix right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes along with that added the build package

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is pretty big. I'm worried about performance for Angular on stackblitz because of all those new dependencies being added. Could we maybe stay on 19.0.5 which seems to had less?

@JeevanMahesha
Copy link
Contributor Author

@Nemikolh as alxhub revert the changes, I'm closing this PR and fix the #49 bug and will raise the new PR.

@alxhub
Copy link
Contributor

alxhub commented Jan 10, 2025

Thanks for your efforts, @JeevanMahesha! Sorry about the revert PR - we noticed that it wasn't possible to create new Angular Stackblitz projects and asked for a quick revert since there was some discussion here on what the right path forward was.

@JeevanMahesha
Copy link
Contributor Author

@alxhub Thank you for the feedback, and I sincerely apologize for the oversight on my part. I should have reviewed it more thoroughly before submitting. Could you kindly review this PR when convenient? I’d appreciate any guidance on the right path forward.

PR link #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants