-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(angular): correct builder path in angular.json and added the @angular-devkit/build-angular package #51
Conversation
@Nemikolh I realized I made a small mistake in my previous PR that was just merged. I caught this issue after checking on Stackblitz.com. I've already made the necessary fix and tested it locally. Could you please review and merge the updated PR at your earliest convenience? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for checking and for the quick PR. Could you submit only the fix in this PR and have the update in a separate PR?
angular/angular.json
Outdated
@@ -37,7 +37,7 @@ | |||
} | |||
}, | |||
"serve": { | |||
"builder": "@@angular-devkit/build-angular:dev-server", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the fix right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes along with that added the build package
angular/package-lock.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is pretty big. I'm worried about performance for Angular on stackblitz because of all those new dependencies being added. Could we maybe stay on 19.0.5
which seems to had less?
Thanks for your efforts, @JeevanMahesha! Sorry about the revert PR - we noticed that it wasn't possible to create new Angular Stackblitz projects and asked for a quick revert since there was some discussion here on what the right path forward was. |
No description provided.