Allow changing configuration options #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set_upgrading_condition leads to conflicts (MERGE vs APPLY; see spark operator)
# Conflicts: # crd/src/lib.rs # crd/zookeepercluster.crd.yaml
# Conflicts: # Cargo.lock # crd/Cargo.toml # crd/src/lib.rs # crd/zookeepercluster.crd.yaml # operator/src/lib.rs # server/Cargo.toml
# Conflicts: # Cargo.lock # crd/Cargo.toml # operator/Cargo.toml # operator/src/lib.rs # server/Cargo.toml # server/src/main.rs
# Conflicts: # Cargo.lock # crd/Cargo.toml # crd/src/lib.rs # crd/zookeepercluster.crd.yaml # operator/src/lib.rs
Changed json config to yaml. Added graceful crd wait if not available.
Renamed ZookeeperRole from "servers" to "server" and adapted config.yaml accordingly.
Changed version v1 to v1alpha1.
# Conflicts: # operator/Cargo.toml # server/Cargo.toml
This was
linked to
issues
Jul 8, 2021
# Conflicts: # crd/Cargo.toml # operator/Cargo.toml
soenkeliebau
approved these changes
Jul 19, 2021
Member
soenkeliebau
left a comment
soenkeliebau
left a comment
There was a problem hiding this comment.
LGTM (haven't tested the error handling myself, but discussed with @maltesander and he looked at it)
stackable-bot
added a commit
that referenced
this pull request
Feb 10, 2022
…ackabletech/operator-templating repo. Original commit message: Adds missing --- start token to please yamllint (#71)
bors bot
pushed a commit
that referenced
this pull request
Feb 10, 2022
Automatically created PR based on commit 5da434fdc7a60487b12badfdc8c5458dfb4b66da in stackabletech/operator-templating repo. Original commit message: Adds missing --- start token to please yamllint (#71)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains multiple changes: