fix: Place internal secrets in mutable Kubernetes Secrets#876
Open
fix: Place internal secrets in mutable Kubernetes Secrets#876
Conversation
2 tasks
razvan
approved these changes
Apr 2, 2026
Member
razvan
left a comment
There was a problem hiding this comment.
small remark, otherwise it lgtm
| secret_key.to_string(), | ||
| get_random_base64(secret_byte_size), | ||
| )])), | ||
| ..Secret::default() |
Member
There was a problem hiding this comment.
I would prefer to make immutable: false explicit here too.
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of stackabletech/issues#843
This PR also
Testing
Tested from-scratch install:
As well as and update from 0.0.0-dev:
Follow-up
It seems a bit silly to-copy paste this to airflow, IMHO we should put something like this into operator-rs
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker