-
-
Notifications
You must be signed in to change notification settings - Fork 8
chore: add test and docs for metrics #764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The AWS metrics test will not work like this but I'm personally also fine if you remove it.
host_coordinator_0 = ( | ||
"http://trino-coordinator-default-0.trino-coordinator-default." | ||
+ namespace | ||
+ ".svc.cluster.local" | ||
) | ||
host_worker_0 = ( | ||
"http://trino-worker-default-0.trino-worker-default." | ||
+ namespace | ||
+ ".svc.cluster.local" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
host_coordinator_0 = ( | |
"http://trino-coordinator-default-0.trino-coordinator-default." | |
+ namespace | |
+ ".svc.cluster.local" | |
) | |
host_worker_0 = ( | |
"http://trino-worker-default-0.trino-worker-default." | |
+ namespace | |
+ ".svc.cluster.local" | |
) | |
host_coordinator_0 = f"http://trino-coordinator-default-0.trino-coordinator-default.{namespace}.svc.cluster.local" | |
host_worker_0 = f"http://trino-worker-default-0.trino-worker-default.{namespace}.svc.cluster.local" |
retries = 3 | ||
for i in range(retries): | ||
try: | ||
r = requests.get(url, timeout=5, auth=("trino", "")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the wrong auth credentials. On AWS admin/admin should work. Maybe also bob/bob.
namespace = args["namespace"] | ||
|
||
host_coordinator_0 = ( | ||
"http://trino-coordinator-default-0.trino-coordinator-default." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs https
on AWS.
Description
Part of stackabletech/issues#735
Trino already provides built-in Prometheus metrics per default. This PR adds testing the metrics endpoint and some documentation.
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecation
label & add to the deprecation scheduletype/experimental
label & add to the experimental features tracker