Skip to content

Feat: Trino Listener Integration #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Feat: Trino Listener Integration #753

wants to merge 31 commits into from

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Jun 5, 2025 •
edited
Loading

Description

fixes #700

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@maltesander maltesander self-assigned this Jun 5, 2025
@maltesander maltesander marked this pull request as ready for review June 6, 2025 11:59
NickLarsenNZ
NickLarsenNZ reviewed Jun 18, 2025
View reviewed changes
rust/operator-binary/src/listener.rs
&ListenerReference::ListenerName(group_listener_name.to_string()),
unversioned_recommended_labels,
)
.context(BuildListenerPersistentVolumeSnafu)?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, the new method always returns Ok(). Ideally it should be fixed in stackable-operator: https://github.com/stackabletech/operator-rs/blob/c0c928f336e7f784eb2a869adb3228fe704f88c9/crates/stackable-operator/src/builder/pod/volume.rs#L501-L504

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solved by this PR: stackabletech/operator-rs#1058

NickLarsenNZ
NickLarsenNZ reviewed Jun 18, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@maltesander maltesander

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate Trino Operator with Listener Operator
2 participants
@maltesander @NickLarsenNZ