Skip to content

fix: Only delete queries from persistence if the query is finished #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sbernauer merged 5 commits into from
Jan 14, 2026
Merged

fix: Only delete queries from persistence if the query is finished #98

sbernauer merged 5 commits into from
Jan 14, 2026
+78 −25

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Dec 15, 2025 •
edited
Loading

Hopefully fixes #97

--- PASS: kuttl (993.44s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_trino-lb-foo_bar_trino-451_persistence-redis (188.35s)
        --- PASS: kuttl/harness/smoke_trino-lb-foo_bar_trino-476_persistence-postgres (183.36s)
        --- PASS: kuttl/harness/client-spooling_trino-lb-foo_bar_trino-client-spooling-476_client-spooling-retrieval-mode-COORDINATOR_PROXY (384.88s)
        --- PASS: kuttl/harness/smoke_trino-lb-foo_bar_trino-476_persistence-inMemory (108.33s)
        --- PASS: kuttl/harness/smoke_trino-lb-foo_bar_trino-476_persistence-redis (183.05s)
        --- PASS: kuttl/harness/smoke_trino-lb-foo_bar_trino-451_persistence-inMemory (101.28s)
        --- PASS: kuttl/harness/smoke_trino-lb-foo_bar_trino-451_persistence-postgres (186.64s)
        --- PASS: kuttl/harness/client-spooling_trino-lb-foo_bar_trino-client-spooling-476_client-spooling-retrieval-mode-STORAGE (398.94s)
PASS

@sbernauer sbernauer self-assigned this Dec 15, 2025
@sbernauer sbernauer mentioned this pull request Dec 15, 2025
Open
2 tasks
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Jan 13, 2026
@maltesander maltesander self-requested a review January 13, 2026 13:23
@maltesander maltesander moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jan 13, 2026
maltesander
maltesander requested changes Jan 13, 2026
View reviewed changes
sbernauer and others added 2 commits January 14, 2026 08:04
@sbernauer @maltesander
Update CONTRIBUTING.md
a5df05e 
Co-authored-by: Malte Sander <[email protected]>
@sbernauer @maltesander
Update CONTRIBUTING.md
3f4a1c5 
Co-authored-by: Malte Sander <[email protected]>
@sbernauer sbernauer requested a review from maltesander January 14, 2026 07:06
maltesander
maltesander approved these changes Jan 14, 2026
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer added this pull request to the merge queue Jan 14, 2026
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Jan 14, 2026
Merged via the queue into main with commit 045a3d1 Jan 14, 2026
9 checks passed
@sbernauer sbernauer deleted the fix/better-query-finished-handling branch January 14, 2026 07:25
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

@sbernauer sbernauer

Labels

None yet

Projects

Stackable Engineering
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add proper support for Trinos with client spooling enabled

3 participants

@sbernauer @maltesander