Skip to content

fix(stackable-versioned): Handle fields added in later versions #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 14, 2025

Conversation

Techassi
Copy link
Member

Found by @sbernauer

#[versioned(
    version(name = "v1alpha1"),
    version(name = "v1alpha2"),
    version(name = "v1beta1"),
    version(name = "v1")
)]
struct Foo {
    username: String,

    #[versioned(added(since = "v1alpha2"))]
    first_name: String,

    #[versioned(added(since = "v1beta1"))]
    last_name: String,
}

@Techassi Techassi self-assigned this May 13, 2025
@Techassi Techassi moved this to Development: Waiting for Review in Stackable Engineering May 13, 2025
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering May 13, 2025
sbernauer
sbernauer previously approved these changes May 13, 2025
@Techassi Techassi enabled auto-merge May 13, 2025 12:58
@Techassi Techassi disabled auto-merge May 13, 2025 12:58
@Techassi Techassi enabled auto-merge May 13, 2025 13:01
@Techassi Techassi added this pull request to the merge queue May 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 13, 2025
@sbernauer sbernauer added this pull request to the merge queue May 14, 2025
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering May 14, 2025
@sbernauer sbernauer removed this pull request from the merge queue due to a manual request May 14, 2025
@sbernauer sbernauer added this pull request to the merge queue May 14, 2025
@Techassi Techassi removed this pull request from the merge queue due to a manual request May 14, 2025
@Techassi Techassi closed this May 14, 2025
@Techassi Techassi reopened this May 14, 2025
@Techassi Techassi enabled auto-merge May 14, 2025 07:10
@Techassi Techassi added this pull request to the merge queue May 14, 2025
@NickLarsenNZ NickLarsenNZ removed this pull request from the merge queue due to a manual request May 14, 2025
@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue May 14, 2025
@NickLarsenNZ NickLarsenNZ removed this pull request from the merge queue due to a manual request May 14, 2025
@NickLarsenNZ NickLarsenNZ merged commit 61596d6 into main May 14, 2025
15 checks passed
@NickLarsenNZ NickLarsenNZ deleted the fix/stackable-versioned-added-logic-error branch May 14, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Development: Done
Development

Successfully merging this pull request may close these issues.

3 participants