refactor: Build RBAC with recommended labels#990
Open
adwk67 wants to merge 11 commits into
Open
Conversation
12 tasks
Member
Author
|
siegfriedweber
requested changes
Jul 24, 2026
siegfriedweber
left a comment
Member
There was a problem hiding this comment.
The comments made in stackabletech/hdfs-operator#806 and stackabletech/hive-operator#731 apply here as well.
Comment on lines
-3
to
-5
| //! These build Kubernetes labels/selectors from a [`ValidatedCluster`]. They live here rather | ||
| //! than as methods on [`ValidatedCluster`] so the validated model only exposes views on its | ||
| //! properties, not build-step helpers. |
Member
There was a problem hiding this comment.
Yes, that was the right choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of: stackabletech/issues#869
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker