-
-
Notifications
You must be signed in to change notification settings - Fork 7
chore: ensure metrics are correctly exposed #721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ntainer, adds prometheus annotations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Do we need a changelog entry, as this is sort-of user-facing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Release snippetThis is a combined summary of this PR and the The metrics format changed, so this is possibly breaking (native vs jmx) |
Description
Part of stackabletech/issues#747
This PR adds a metrics service with the additional Prometheus annotations.
The metrics service is also added to the TLS cert in order to scrape the metrics service.
BREAKING:
<stacklet>-<role>-<rolegroup>service to<stacklet>-<role>-<rolegroup>-headless.Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker