feat: HBase resolvable endpoints

[adwk67]

Description

fixes: stackabletech/hbase-operator#641

Warning

Merge this at the same time as stackabletech/hbase-operator#639, otherwise tests will break!

Definition of Done Checklist

Note

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.

Please make sure all these things are done and tick the boxes

• Changes are OpenShift compatible
• All added packages (via microdnf or otherwise) have a comment on why they are added
• Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
• All packages should have (if available) signatures/hashes verified
• Add an entry to the CHANGELOG.md file
• Integration tests ran successfully

TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

[nightkr]

Do we want to pull hbase.info.port into a constant for consistency? For the same reason, we might want to split it into master/regionserver variants?

Also, directionally.. for RPC ports we follow the existing RPC hostname convention of "leave the existing key as the advertised port, introduce a new key for overriding the bound port". I agree that overriding the advertised port instead makes more sense in isolation (and is consistent with kafka et al), but we should probably try to be consistent (both with the rest of our patch and with existing HBase code).

[adwk67]

bd0b75e.

[adwk67]

hbase.info.port is now hbase.master.bound.info.port and hbase.regionserver.bound.info.port.
We are not touching MASTER_INFO_PORT (= "hbase.master.info.port"): is that you meant with "leave the existing key as the advertised port, introduce a new key for overriding the bound port"?

[nightkr]

I'm looking at it now.. MASTER_INFO_PORT is bound (in HRegionServer.putUpWebUI()), MASTER_BOUND_INFO_PORT/useThisInfoPortInstead is advertised. That's.. backwards, at least compared to their names.

[adwk67]

So
public static final String MASTER_BOUND_INFO_PORT = "hbase.master.bound.info.port";
should be renamed to something like:
public static final String MASTER_ADVERTISED_INFO_PORT = "hbase.master.advertised.info.port";
as MASTER_INFO_PORT is already the bound one?

[nightkr]

That would be one way, yeah. But as I said above, I think we should try to be consistent about whether the "old" property (MASTER_INFO_PORT) is for the bound or advertised port.

[adwk67]

I've endeavoured to make that change in a separate patch: ee7ea2e