Skip to content

Remove direct accesses to CustomData #2288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bwhitchurch wants to merge 3 commits into
base: devel
Choose a base branch
from
Open

Remove direct accesses to CustomData #2288

bwhitchurch wants to merge 3 commits into from
+4 −4

Conversation

@bwhitchurch
Copy link

@bwhitchurch bwhitchurch commented Dec 12, 2023 •
edited
Loading

This is related to sstsimulator/sst-core#1001. This patch depends on the interface introduced by sstsimulator/sst-core#1021.

@sst-autotester
Copy link
Contributor

sst-autotester commented Dec 12, 2023

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

@sst-autotester
Copy link
Contributor

sst-autotester commented Jan 9, 2024

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

bwhitchurch
bwhitchurch commented Jan 9, 2024
View reviewed changes
src/sst/elements/osseous/Makefile.am
Copy link
Author

@bwhitchurch bwhitchurch Jan 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

std::exchange is C++14 feature used by CustomResp/Req::set/releaseData(). I'm not sure how long ago PinCRT started supporting new features, but it seems C++17 is on the table since at least 3.26

@hughes-c hughes-c added this to the Future milestone Oct 8, 2024
@sst-autotester
Copy link
Contributor

sst-autotester commented Feb 22, 2025

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Future

Development

Successfully merging this pull request may close these issues.

3 participants

@bwhitchurch @sst-autotester @hughes-c