Skip to content

feat(tui): store/restore shell commands in message history #2007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

yihuikhuu
Copy link
Contributor

fixes #2006

before:

noshellhistory.mov

after:

withshellhistory.mov

@adamdotdevin
Copy link
Contributor

this was actually intentional on my end; do you think they belong in history? i went back and forth on it

@yihuikhuu
Copy link
Contributor Author

Ah fair enough. Thinking about it a bit more, it might pollute the history to add them in there.

It initially felt a bit odd - muscle memory kicked in and I pressed up to replay the command and ended up sending my previous message instead.


For reference, I just checked the behaviour on Claude Code/Gemini:

  • Claude Code has it in the history
  • Gemini splits the history between the normal and bash mode which is interesting (though its a bit buggy - bash command history appears in normal mode when you start a new session)

@yihuikhuu
Copy link
Contributor Author

yihuikhuu commented Aug 18, 2025

Happy to close this since this was an intentional decision though, maybe can revisit if there is similar feedback by others

@adamdotdevin
Copy link
Contributor

yeah, i'm inclined to leave the behavior as is until convinced otherwise by lots of requests

@yihuikhuu
Copy link
Contributor Author

No worries, lets close this off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shell commands are not stored in message history
2 participants